Add support for collection of oracles to chains endpoint #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
previously approved these changes
Sep 2, 2021
| Chain = apps.get_model("chains", "Chain") | ||
| db_alias = schema_editor.connection.alias | ||
|
|
||
| GasPrice.objects.using(db_alias).bulk_create( |
There was a problem hiding this comment.
Just curious, is this using needed?
There was a problem hiding this comment.
I would say that it is not required reading this: https://docs.djangoproject.com/en/3.2/ref/models/querysets/#using
Since we are using just one DB. I think we can remove it 👍
There was a problem hiding this comment.
Removed it here 60342d3
| ) | ||
|
|
||
|
|
||
| class GasPriceSerializer(serializers.Serializer): |
Uxio0
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209
/api/v1/chains: each chain is now allowed to have multiple gas price configurations (resulting in a collection instead of a single object offixedandoraclegas prices).GasPricefor each chain is now ranked – a lower value means that it'd show up higher on the list (eg.:rank 1 > rank 100)GasPricecollection is allowed to be empty – this is not only to reduce complexity but also because the current relationship betweenGasPrice <> Chainmeans that aChainneeds to exist first before assigning aGasPriceto it.