Fix tests

- Fix tx service tests - Fix tracing tests
safe-global · Oct 28, 2022 · 583eb01 · 583eb01
1 parent 5a07537
commit 583eb01
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/gnosis/eth/tests/mocks/mock_trace_block.py b/gnosis/eth/tests/mocks/mock_trace_block.py
@@ -179,7 +179,7 @@
         "blockHash": "0x8f9809f6012f85803956a419e2e54914dfdebba33e4f7a0d1574b12e92499c0e",
         "blockNumber": 13191781,
         "error": "Reverted",
-        "result": None,
+        "result": {"gasUsed": 27856, "output": HexBytes("0x")},
         "subtraces": 0,
         "traceAddress": [],
         "transactionHash": "0xbe99757628bfc3d5c7ee4e42c2629ddd13ac52354e6abb189efe5e277dce05b3",
@@ -746,7 +746,12 @@
         "blockHash": "0x8f9809f6012f85803956a419e2e54914dfdebba33e4f7a0d1574b12e92499c0e",
         "blockNumber": 13191781,
         "error": "Reverted",
-        "result": None,
+        "result": {
+            "gasUsed": 16268,
+            "output": HexBytes(
+                "0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000002b556e69737761705632526f757465723a20494e53554646494349454e545f4f55545055545f414d4f554e54000000000000000000000000000000000000000000"
+            ),
+        },
         "subtraces": 2,
         "traceAddress": [],
         "transactionHash": "0xfac7403428a8213f3fc296412eb3f259086d80dd83be2d819b574b145b8d4855",
@@ -889,7 +894,12 @@
         "blockHash": "0x8f9809f6012f85803956a419e2e54914dfdebba33e4f7a0d1574b12e92499c0e",
         "blockNumber": 13191781,
         "error": "Reverted",
-        "result": None,
+        "result": {
+            "gasUsed": 93884,
+            "output": HexBytes(
+                "0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000164d696e2072657475726e206e6f742072656163686564"
+            ),
+        },
         "subtraces": 5,
         "traceAddress": [],
         "transactionHash": "0xd1118a18e43777636ccef0cafa5de58c3b0c6800454606342ba46a662828a8c6",

diff --git a/gnosis/safe/tests/api/test_transaction_service_api.py b/gnosis/safe/tests/api/test_transaction_service_api.py
@@ -11,12 +11,12 @@
 class TestTransactionServiceAPI(EthereumTestCaseMixin, TestCase):
     def setUp(self) -> None:
         self.transaction_service_api = TransactionServiceApi(
-            EthereumNetwork.RINKEBY, ethereum_client=self.ethereum_client
+            EthereumNetwork.GOERLI, ethereum_client=self.ethereum_client
         )
-        self.safe_address = "0x7552Ed65a45E27740a15B8D5415E90d8ca64C109"
+        self.safe_address = "0x24833C9c4644a70250BCCBcB5f8529b609eaE6EC"
 
     def test_constructor(self):
-        ethereum_network = EthereumNetwork.RINKEBY
+        ethereum_network = EthereumNetwork.GOERLI
         base_url = "https://safe.global"
         transaction_service_api = TransactionServiceApi(
             ethereum_network, ethereum_client=None, base_url=base_url
@@ -30,15 +30,15 @@ def test_from_ethereum_client(self):
             TransactionServiceApi.from_ethereum_client(self.ethereum_client)
 
         with mock.patch.object(
-            EthereumClient, "get_network", return_value=EthereumNetwork.RINKEBY
+            EthereumClient, "get_network", return_value=EthereumNetwork.GOERLI
         ):
             transaction_service_api = TransactionServiceApi.from_ethereum_client(
                 self.ethereum_client
             )
             self.assertEqual(
                 transaction_service_api.ethereum_client, self.ethereum_client
             )
-            self.assertEqual(transaction_service_api.network, EthereumNetwork.RINKEBY)
+            self.assertEqual(transaction_service_api.network, EthereumNetwork.GOERLI)
 
     def test_data_decoded_to_text(self):
         test_data = {