Dont respect retry_after_header #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, if a `RetryAfter` header is set it will overwrite our retry policy - We should be the ones deciding on the retry policy - More info on https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After
Pull Request Test Coverage Report for Build 9517297034Details
💛 - Coveralls |
fmrsabino
reviewed
Jun 18, 2024
| @@ -15,8 +15,7 @@ def prepare_http_session( | |||
| session = requests.Session() | |||
| retry_conf = ( | |||
| requests.adapters.Retry( | |||
| total=retry_count, | |||
| backoff_factor=0.3, | |||
| total=retry_count, backoff_factor=0.3, respect_retry_after_header=False | |||
There was a problem hiding this comment.
Out of curiosity, wouldn't the server know better when we should attempt to retry the connection?
What are the use cases that you are thinking of where this decision should be on the client side?
There was a problem hiding this comment.
Maybe the service knows better in some scenarios. But for example some services tell you to retry in one hour, for example, blocking the request forever, and I see that happening with some RPCs (that's why I proposed this PR)
fmrsabino
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RetryAfterheader is set it will overwrite our retry policy