Port py-eth-sig-utils to eip712-structs #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banteg
force-pushed
the
feat/eip712-structs
branch
from
8599a37
to
961637d
Compare
Uxio0
requested changes
Nov 5, 2021
gnosis/safe/safe_tx.py
Outdated
| structured_data["domain"]["chainId"] = self.chain_id | ||
| if safe_version >= Version("1.0.0"): | ||
|
|
||
| class SafeTx(EIP712Struct): |
There was a problem hiding this comment.
I wouldn't define this class in an if, I think it's better to do it at the beginning of the safe_tx.py file. Then define 2 classes, LegacySafeTx and SafeTx and use them on the if clause
There was a problem hiding this comment.
Makes sense, pushed this change.
Uxio0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed @Uxio0 suggestion from here #120 (review)
Rewrote EIP712 code of SafeTx to match the library used in Protocol. Removed
py-eth-sig-utilsdependency.