Detect MultiSend addresses #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2656170144
💛 - Coveralls |
bh2smith
approved these changes
Jul 11, 2022
gnosis/safe/multi_send.py
Outdated
| "%s proxy factory address not valid" % address | ||
| ) | ||
| def __init__( | ||
| self, ethereum_client: EthereumClient, address: Optional[ChecksumAddress] = None |
There was a problem hiding this comment.
I know its probably too much to ask, but you think we can also pass along a Dummy EthereumClient here? I am just hoping for some way of encoding the function call build_tx_data(transactions).
Comment on lines
+182
to
+185
| assert fast_is_checksum_address(address), ( | ||
| "%s proxy factory address not valid" % address | ||
| ) |
There was a problem hiding this comment.
Probably off topic, but is there any reason you don't enforce that the address input is a ChecksumAddress?
There was a problem hiding this comment.
I'm already checking if it's a ChecksumAddress
Uxio0
force-pushed
the
detect-multisend-address
branch
from
4d41101
to
3f6f9d5
Compare
Uxio0
force-pushed
the
detect-multisend-address
branch
from
3f6f9d5
to
a4aa663
Compare
moisses89
reviewed
Jul 12, 2022
| MULTISEND_ADDRESSES = ( | ||
| "0xA238CBeb142c10Ef7Ad8442C6D1f9E89e07e7761", | ||
| "0x998739BFdAAdde7C933B942a68053933098f9EDa", | ||
| ) |
There was a problem hiding this comment.
There is any reason to use Tuple instead List?
There was a problem hiding this comment.
It's not very relevant, but Tuple is inmutable and in this case we don't plan on modifying it
moisses89
approved these changes
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressfield Optional #283