Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit batch requests #302

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Limit batch requests #302

merged 2 commits into from
Jul 13, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jul 13, 2022 •
edited
Loading

@Uxio0
Limit batch requests
d100fcd 
- Add new environment variable ETHEREUM_RPC_BATCH_REQUEST_MAX_SIZE to set the limit
- Refactor batch requests code
@coveralls
Copy link

coveralls commented Jul 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2663241220

  • 43 of 48 (89.58%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 90.951%
Changes Missing Coverage Covered Lines Changed/Added Lines %
gnosis/eth/ethereum_client.py 39 44 88.64%
Totals Coverage Status
Change from base Build 2656751926: -0.08%
Covered Lines: 2995
Relevant Lines: 3293
💛 - Coveralls

@Uxio0 Uxio0 merged commit 846c533 into master Jul 13, 2022
@Uxio0 Uxio0 deleted the limit-batch-requests branch July 13, 2022 12:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limit number of payloads in the same batch request
3 participants
@Uxio0 @coveralls @fmrsabino