Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other networks than Mainnet for Sushiswap #344

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Support other networks than Mainnet for Sushiswap #344

merged 1 commit into from
Sep 7, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Sep 2, 2022

@Uxio0 Uxio0 requested a review from a team as a code owner September 2, 2022 14:16
@coveralls
Copy link

coveralls commented Sep 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2992761745

  • 44 of 53 (83.02%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 89.879%
Changes Missing Coverage Covered Lines Changed/Added Lines %
gnosis/eth/oracles/kyber.py 33 42 78.57%
Totals Coverage Status
Change from base Build 2992419815: -0.07%
Covered Lines: 3428
Relevant Lines: 3814
💛 - Coveralls

@Uxio0
Support other networks than Mainnet for Sushiswap
9cbe858 
- Organize Sushiswap and Kyber oracles files
- Related to #343
@Uxio0 Uxio0 merged commit 17c26c7 into master Sep 7, 2022
@Uxio0 Uxio0 deleted the add-networks-sushiswap branch September 7, 2022 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @hectorgomezv