Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: register acala, karura, and mandala etherscan urls #352

Merged
merged 2 commits into from
Sep 16, 2022
Merged

feat: register acala, karura, and mandala etherscan urls #352

merged 2 commits into from
Sep 16, 2022

Conversation

the-amazing-ultraton
Copy link
Contributor

No description provided.

@the-amazing-ultraton the-amazing-ultraton requested a review from a team as a code owner September 6, 2022 16:04
@coveralls
Copy link

coveralls commented Sep 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3048047824

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 205 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-5.4%) to 84.597%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/multicall.py 9 86.41%
gnosis/eth/oracles/kyber.py 10 52.27%
gnosis/eth/oracles/uniswap_v3.py 23 57.81%
gnosis/eth/ethereum_client.py 39 81.24%
gnosis/eth/oracles/oracles.py 124 49.84%
Totals Coverage Status
Change from base Build 3006987365: -5.4%
Covered Lines: 3202
Relevant Lines: 3785
💛 - Coveralls

@Uxio0
Copy link
Member

Uxio0 commented Sep 7, 2022

This needs a rebase

@Uxio0 Uxio0 merged commit 9865a0f into safe-global:master Sep 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@the-amazing-ultraton @coveralls @Uxio0