Add Cowswap oracle #353
Merged
Add Cowswap oracle #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Sep 9, 2022
Uxio0
commented
- Related to Use CowSwap as a price oracle on Mainnet/Gnosis Chain safe-transaction-service#645
Pull Request Test Coverage Report for Build 3022306946
💛 - Coveralls |
fmrsabino
approved these changes
Sep 16, 2022
| if "amount" in result: | ||
| # Decimals needs to be adjusted | ||
| token_2_decimals = get_decimals(token_address_2, self.ethereum_client) | ||
| return float(result["amount"]) / 10**token_2_decimals |
There was a problem hiding this comment.
Should we use fractions here since we are dealing with financial decimal values?
There was a problem hiding this comment.
That's a good idea, but I wouldn't do it as it would break oracle interface for all the implemented oracles. At some point we can refactor all the oracles to return Fraction
|
|
||
| class TestCowswapOracle(EthereumTestCaseMixin, TestCase): | ||
| def test_get_price(self): | ||
| mainnet_node = just_test_if_mainnet_node() |
There was a problem hiding this comment.
OOC: is this testing the real node (E2E)?
There was a problem hiding this comment.
That's right, we are doing E2E for all oracle providers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.