Add method to check if Oracle is available for network #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Sep 20, 2022
Uxio0
commented
- This way it can be queried and no knowledge about the Oracle is required from the user
- This way it can be queried and no knowledge about the Oracle is required from the user
Pull Request Test Coverage Report for Build 3091100501
💛 - Coveralls |
fmrsabino
approved these changes
Sep 21, 2022
Comment on lines
+269
to
+272
| cls.ROUTER_ADDRESSES.get( | ||
| ethereum_client.get_network(), | ||
| cls.ROUTER_ADDRESSES[EthereumNetwork.MAINNET], | ||
| ) |
There was a problem hiding this comment.
Why do we default to Mainnet in for UniswapV2Oracle but not for UniswapOracle?
There was a problem hiding this comment.
Because Uniswap used deterministic deployment for V2 but not for V1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.