Migrate setup.py to setup.cfg #357
Conversation
Uxio0
force-pushed
the
migrate-setup-py
branch
from
f51ec11
to
9de68f8
Compare
- Remove pyproject.toml, it was breaking local install (`pip -e ...`) - Set version 4.5.0
Uxio0
force-pushed
the
migrate-setup-py
branch
from
9de68f8
to
067a2de
Compare
Pull Request Test Coverage Report for Build 3105302545
💛 - Coveralls |
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2018 Gnosis Ltd | |||
| Copyright (c) 2018 Safe Ecosystem Foundation | |||
There was a problem hiding this comment.
Maybe different PR like update license?
There was a problem hiding this comment.
Well, it was suposed to be updated some months ago, so I just fixed it. If you think it's necessary I will create a new PR 😉
There was a problem hiding this comment.
I also agree with @moisses89 but just because I think it brings more context to the changes going in.
| @@ -1,6 +1,6 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2018 Gnosis Ltd | |||
| Copyright (c) 2018 Safe Ecosystem Foundation | |||
There was a problem hiding this comment.
I also agree with @moisses89 but just because I think it brings more context to the changes going in.
| @@ -1,3 +1,68 @@ | |||
| [metadata] | |||
| name = safe-eth-py | |||
| version = 4.5.0 | |||
There was a problem hiding this comment.
The version changed here. Not sure if this is intended.
There was a problem hiding this comment.
Yes, it's intended, I wanted to have the version ready asap so I can use it on the tx service and deploy it next week
pip -e ...)