Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check liquidity for Uniswap V3 oracle #361

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Check liquidity for Uniswap V3 oracle #361

merged 2 commits into from
Sep 28, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Sep 28, 2022

  • If there's not enough liquidity price can get crazy

@Uxio0
Check liquidity for Uniswap V3 oracle
d54202c 
- If there's not enough liquidity price can get crazy
@Uxio0
Set version 4.5.1
f8fa789
@Uxio0 Uxio0 requested a review from a team as a code owner September 28, 2022 11:44
@coveralls
Copy link

coveralls commented Sep 28, 2022 •
edited

Pull Request Test Coverage Report for Build 3143251707

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 83.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
gnosis/eth/oracles/uniswap_v3.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/oracles/uniswap_v3.py 1 55.71%
Totals Coverage Status
Change from base Build 3126550209: 0.2%
Covered Lines: 3252
Relevant Lines: 3873
💛 - Coveralls

moisses89
moisses89 reviewed Sep 28, 2022
View reviewed changes
gnosis/eth/tests/oracles/test_uniswap_v3.py
@@ -59,6 +59,15 @@ def test_get_price(self):
):
uniswap_v3_oracle.get_price(random_token)

# Test token with no liquidity
s_usd_token_mainnet_address = "0x57Ab1ec28D129707052df4dF418D58a2D46d5f51"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm wrong but could be that in the future this token have liquidity?

Copy link
Member Author

@Uxio0 Uxio0 Sep 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, then test will break and we will have to find another one or mock it 😉

@Uxio0 Uxio0 merged commit d7aa478 into master Sep 28, 2022
@Uxio0 Uxio0 deleted the check-liquidity branch September 28, 2022 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @moisses89