Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check liquidity for tokens in UniswapV3 oracle #367

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Check liquidity for tokens in UniswapV3 oracle #367

merged 1 commit into from
Oct 10, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Oct 6, 2022

  • Make sure there are at least 2 unit of each token

@Uxio0 Uxio0 requested a review from a team as a code owner October 6, 2022 16:34
@coveralls
Copy link

coveralls commented Oct 6, 2022 •
edited

Pull Request Test Coverage Report for Build 3220003476

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 83.91%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/oracles/uniswap_v3.py 22 56.34%
Totals Coverage Status
Change from base Build 3217972053: 0.2%
Covered Lines: 3275
Relevant Lines: 3903
💛 - Coveralls

moisses89
moisses89 requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only a little change.

gnosis/eth/tests/oracles/test_uniswap_v3.py Outdated Show resolved Hide resolved
@Uxio0
Check liquidity for tokens in UniswapV3 oracle
5bb5278 
- Make sure there are at least 2 unit of each token
@Uxio0 Uxio0 merged commit 15d5a0f into master Oct 10, 2022
@Uxio0 Uxio0 deleted the check-liquidity-uniswap-v3 branch October 10, 2022 14:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @moisses89