Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP155 support for some methods #477

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Add EIP155 support for some methods #477

merged 2 commits into from
Mar 23, 2023

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Mar 17, 2023

@Uxio0
Add EIP155 support for some methods
86bbb31 
- Some methods on `EthereumClient` did not support EIP155
- Closes #476
@Uxio0 Uxio0 requested a review from a team as a code owner March 17, 2023 13:07
@Uxio0 Uxio0 requested review from moisses89 and hectorgomezv and removed request for a team March 17, 2023 13:07
@Uxio0
Copy link
Member Author

Uxio0 commented Mar 17, 2023

Merge #478 first to fix tests

@coveralls
Copy link

coveralls commented Mar 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4448339334

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 90.573%
Totals Coverage Status
Change from base Build 4448334146: 0.07%
Covered Lines: 3776
Relevant Lines: 4169
💛 - Coveralls

moisses89
moisses89 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Uxio0 Uxio0 merged commit 00cf237 into master Mar 23, 2023
@Uxio0 Uxio0 deleted the fix-eip155-tx branch March 23, 2023 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @moisses89