Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Crossbell chain #488

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Add Crossbell chain #488

merged 1 commit into from
Mar 29, 2023

Conversation

iavl
Copy link
Contributor

@iavl iavl commented Mar 29, 2023

No description provided.

@iavl iavl requested a review from a team as a code owner March 29, 2023 01:09
@iavl iavl requested review from Uxio0, moisses89 and hectorgomezv and removed request for a team March 29, 2023 01:09
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@iavl
Copy link
Contributor Author

iavl commented Mar 29, 2023

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 29, 2023
@github-actions
@iavl has signed the CLA in #488
831567c
moisses89
moisses89 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4549165793

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 248 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-5.9%) to 84.625%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/multicall.py 9 88.35%
gnosis/eth/oracles/superfluid.py 9 55.0%
gnosis/eth/oracles/kyber.py 11 59.18%
gnosis/eth/oracles/cowswap.py 22 35.14%
gnosis/eth/oracles/uniswap_v3.py 28 56.34%
gnosis/eth/ethereum_client.py 38 81.52%
gnosis/eth/oracles/oracles.py 131 50.46%
Totals Coverage Status
Change from base Build 4534326501: -5.9%
Covered Lines: 3528
Relevant Lines: 4169
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Mar 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4549165793

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 248 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-5.9%) to 84.625%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/multicall.py 9 88.35%
gnosis/eth/oracles/superfluid.py 9 55.0%
gnosis/eth/oracles/kyber.py 11 59.18%
gnosis/eth/oracles/cowswap.py 22 35.14%
gnosis/eth/oracles/uniswap_v3.py 28 56.34%
gnosis/eth/ethereum_client.py 38 81.52%
gnosis/eth/oracles/oracles.py 131 50.46%
Totals Coverage Status
Change from base Build 4534326501: -5.9%
Covered Lines: 3528
Relevant Lines: 4169
💛 - Coveralls

@moisses89 moisses89 merged commit 1740539 into safe-global:master Mar 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iavl @coveralls @moisses89