Add Ens Client #814
Merged
Add Ens Client #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
reviewed
Mar 5, 2024
| from gnosis.eth import EthereumNetwork | ||
|
|
||
|
|
||
| class EnsClient: |
There was a problem hiding this comment.
Suggested change
| class EnsClient: | |
| class EnsClient: | |
| """ | |
| Resolves Ethereum Name Service domains using ``thegraph`` API | |
| """ |
Uxio0
reviewed
Mar 5, 2024
gnosis/eth/clients/ens_client.py
Outdated
| self.request_timeout = 5 # Seconds | ||
| self.request_session = requests.Session() | ||
|
|
||
| def is_available(self): |
There was a problem hiding this comment.
Suggested change
| def is_available(self): | |
| def is_available(self) -> bool: |
Uxio0
reviewed
Mar 5, 2024
gnosis/eth/clients/ens_client.py
Outdated
| return False | ||
|
|
||
| @staticmethod | ||
| def domain_hash_to_hex_str(domain_hash: Union[str, bytes, int]) -> str: |
There was a problem hiding this comment.
Suggested change
| def domain_hash_to_hex_str(domain_hash: Union[str, bytes, int]) -> str: | |
| def domain_hash_to_hex_str(domain_hash: Union[HexStr, bytes, int]) -> HexStr: |
Uxio0
reviewed
Mar 5, 2024
gnosis/eth/clients/ens_client.py
Outdated
| return None | ||
|
|
||
| def query_by_domain_hash( | ||
| self, domain_hash: Union[str, bytes, int] |
There was a problem hiding this comment.
Suggested change
| self, domain_hash: Union[str, bytes, int] | |
| self, domain_hash: Union[HexStr, bytes, int] |
Uxio0
reviewed
Mar 5, 2024
gnosis/eth/clients/ens_client.py
Outdated
|
|
||
| @lru_cache | ||
| @cache_memoize(60 * 60 * 24, prefix="ens-_query_by_domain_hash") # 1 day | ||
| def _query_by_domain_hash(self, domain_hash_str: str) -> Optional[str]: |
There was a problem hiding this comment.
Suggested change
| def _query_by_domain_hash(self, domain_hash_str: str) -> Optional[str]: | |
| def _query_by_domain_hash(self, domain_hash_str: HexStr) -> Optional[str]: |
Uxio0
reviewed
Mar 5, 2024
requirements.txt
Outdated
| @@ -1,4 +1,5 @@ | |||
| django==4.2.10 | |||
| django-cache-memoize==0.2.0 | |||
There was a problem hiding this comment.
Don't use cache-memoize, standard library should be enough
There was a problem hiding this comment.
Ok, is gnosis.util.cache correct here?
There was a problem hiding this comment.
Yes, it's a wrapper around functools.cache as it was added in Python 3.9 : https://docs.python.org/3/library/functools.html#functools.cache
Uxio0
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #754