Create GitHub Issue template and GitHub action for add new Safe addresses #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
requested changes
Mar 19, 2024
moisses89
reviewed
Mar 20, 2024
.github/scripts/github_adding_addresses/create_pr_with_new_address.py
Outdated
Show resolved
Hide resolved
Uxio0
approved these changes
Mar 20, 2024
@Uxio0 I will try to validate the process in this repo first and will do a follow up with the indications in the readme. Do you agree? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #826
To be considered:
Once the issue is created or edited there is a validator that will help us before executing the "/execute" command to check that all the fields are ok.
To check that the "/execute" command is executed by someone from the "core-api" team, you need to configure a new SECRET in the repository with permissions to read the teams. The secret will be called "TOKEN_GITHUB_READ_ORG_TEAMS" and is configured in the project settings under secrets and actions.