Refactor SafeOperation #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make class inmutable - Add proper caches - Return `valid_after` and `valid_until` as datetime
Uxio0
force-pushed
the
convert-safe-operation-valid
branch
from
8bba81e
to
9ce4c9a
Compare
falvaradorodriguez
approved these changes
Mar 20, 2024
moisses89
approved these changes
Mar 20, 2024
moisses89
reviewed
Mar 20, 2024
| @@ -75,6 +80,63 @@ def from_user_operation(cls, user_operation: UserOperation): | |||
| user_operation.signature[12:], | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _parse_epoch(epoch: int) -> Optional[datetime.datetime]: | |||
There was a problem hiding this comment.
Maybe this would be better in a utils file.
There was a problem hiding this comment.
This is only for this class, as usually we don't want to ignore the exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valid_afterandvalid_untilas datetime