Add pre-commit execution when creating automatic PRs #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
approved these changes
Apr 16, 2024
| @@ -66,6 +66,7 @@ jobs: | |||
| run: | | |||
| pip install safe-eth-py | |||
| pip install validators | |||
| pip install tldextract | |||
There was a problem hiding this comment.
You can install everything in the same line pip install safe-eth-py validators tldextract
moisses89
approved these changes
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Points of interest:
Added pre-commit execution when creating automatic PRs of adding new addresses. In some times with very high block number the maximum line size of the linter is exceeded. This way we ensure that the CI process is not broken.
Updated the way to check the urls of Blockscout and Etherscan clients. In some tests it has been detected that the netloc check was not sufficient.