-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/typo httpresponse error #228
Fix/typo httpresponse error #228
Conversation
050c296
to
0bc169d
Compare
messageContext: { | ||
event: parsedMessage, | ||
httpRequest: { | ||
url: url, | ||
startTime: startTime, | ||
}, | ||
httpResponse: null, | ||
httpResponse: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this is not accurate. There's no httpResponse
as request
couldn't be made. I would propose:
httpRequest: {
url: url,
startTime: startTime,
error: errorMessage,
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed another object to store inside the errors when a response cannot send or is not received. The new object proposed is httpRequestError.
No description provided.