Add basic setup script #47
Conversation
| && docker compose exec txs-web python manage.py createsuperuser \ | ||
| || exit | ||
|
|
||
| echo "==> $(date +%H:%M:%S) ==> All set! You may want to add a ChainInfo into the Config service. Please use the link below to fill its data: http://localhost:8000/cfg/admin/chains/chain/add/" |
There was a problem hiding this comment.
The third task of the issue is add ChainInfo, if you are using a default RPC for Polygon why don't add basic chainInfo for Polygon ❓
There was a problem hiding this comment.
Also, when creating superusers, is expected for the user to input the password, right?
There was a problem hiding this comment.
The third task of the issue is add ChainInfo, if you are using a default RPC for Polygon why don't add basic chainInfo for Polygon ❓
If I recall correctly (because there was a while since 🙂 ) we concluded that maybe it's better to let the user enter the ChainInfo using the Django admin (context here). But I'm open to change it if you think we could make a REST call to retrieve the ChainInfo and inserting it (would require another PR to create the admin command in the Config Service) 🙂
Also, when creating superusers, is expected for the user to input the password, right?
Yes, the script execution waits until the user writes the desired username/password. Is this correct?
scripts/run_locally.sh
Outdated
| || exit | ||
|
|
||
| echo "==> $(date +%H:%M:%S) ==> Using http://polygon-rpc.com as default RPC node" | ||
| sed -i '' 's|http://url.to.node|https://polygon-rpc.com|g' $TEMP \ |
There was a problem hiding this comment.
I wouldn't do it here, I don't feel it very intuitive to tell the user to edit this file to get the node they want, and in the case we want it maybe set http://polygon-rpc.com inside a variable, like NODE_URL=http://polygon-rpc.com so you can reuse it also in the echo
There was a problem hiding this comment.
Yes, I agree, I saw this file like something the user wouldn't touch, but maybe it's a bit confusing, in the case they actually want to change the RPC url, to modify this file. What do you think it's a better option here?
- Setting a
NODE_URLvariable inside this file. - Just including the default RPC url in the
.env.samplefile. - Not setting a default at all, so the script will fail if the users don't set the RPC url themselves.
- Do you see another option?
🙂
There was a problem hiding this comment.
I think users should configure .env as stated in the docs with the node they need and the rest of the configuration should be going on from there
There was a problem hiding this comment.
I've removed .env manipulation from the script in this commit. Now it just starts Docker containers and manages superuser creation 🙂
hectorgomezv
dismissed
moisses89’s stale review
Agreed on populating ChainInfo manually, please contact me if you think we need to do it programatically, I'll open another PR :)
Closes #4
This is a very simple script to just start the Docker containers and create the superusers. As we discussed we can stay simple and let the user insert the ChainInfo. I updated the
README.mdfile accordingly.