Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Crash on ipads when ledger nano X is used #2464

Open
liliya-soroka opened this issue Jul 5, 2022 · 6 comments
Open

[iOS] Crash on ipads when ledger nano X is used #2464

liliya-soroka opened this issue Jul 5, 2022 · 6 comments
Assignees
@DmitryBespalov
Labels
App/Transactions Transactions area bug Doesn't work as expected Major Fix within 2 weeks

Comments

@liliya-soroka
Copy link
Member

Bug description
https://console.firebase.google.com/u/0/project/safe-firebase-mainnet/crashlytics/app/ios:io.gnosis.multisig.prod.mainnet/issues/d1ae589cdfd16b4ada3c0c5cdeafcb69?time=last-seven-days&types=crash&sessionEventKey=25cbe08d14504081926cade37a2e81a1_1693344251816322517
Steps To Reproduce
?
Expected Result
No crash

Device & App version

  • Device/OS: ipad
  • App version: 3.13.0 (1181)

Environment
prod
Additional info
(Optional)
@liliya-soroka liliya-soroka added the bug Doesn't work as expected label Jul 5, 2022
@DmitryBespalov DmitryBespalov added the App/Transactions Transactions area label Jul 6, 2022
@gglucass
Copy link

Any updates on the resolution of this bug by any chance @liliya-soroka :-)?

@liliya-soroka liliya-soroka mentioned this issue Nov 10, 2022
Closed
1 task
@olofedlund
Copy link

FYI, I verified that I could sign with the Nano X on my iPhone. So now we know that this same Nano X works on the iPhone but not on the iPad.

@DmitryBespalov DmitryBespalov added the Major Fix within 2 weeks label Nov 11, 2022
@DmitryBespalov
Copy link
Collaborator

The crashlytics doesn't show the crash anymore. The only information shown is:

-[UIPopoverPresentationController presentationTransitionWillBegin]

Plus, the fact that it crashes on iPad - this makes it clear what's causing the crash.

@DmitryBespalov DmitryBespalov self-assigned this Aug 10, 2023
DmitryBespalov added a commit that referenced this issue Aug 10, 2023
@DmitryBespalov
GH-2464 fix crashing on presentation of an actionSheet on iPad
c7e927c 
Handles #2464

* Added extension to UIAlertController.Style
* Converted most of the .actionSheet to .multiplatformActionSheet to use 'alert' style on macOS and iPad
@DmitryBespalov DmitryBespalov mentioned this issue Aug 10, 2023
Merged
DmitryBespalov added a commit that referenced this issue Aug 10, 2023
@DmitryBespalov
Merge pull request #3288 from safe-global/GH-2464/ipad-crashes
d005f3f 
GH-2464 fix crashing on presentation of an actionSheet on iPad
@liliya-soroka
Copy link
Member Author

Can not enable push notification ( sign with ledger)

tested on
Image

Image

@liliya-soroka
Copy link
Member Author

liliya-soroka commented Sep 19, 2023 •
edited

The issue was checked on the real Ipad. The app crashes on sing push notification request

DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 bump version
40cfd04
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 update packages
4bdbbc6
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 revert package to previous version
5bf8bd2
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 protecting from the crashes related to alert controllers
604eb22
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 crash fixes and sample notification payload for testing
571ae05
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 update packages
abbfbc4
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 update config
4df8374
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
Revert "GH-2464 update packages"
d4d53d4 
This reverts commit abbfbc4.
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
Revert "GH-2464 update config"
5dd85c5 
This reverts commit 4df8374.
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 re-apply package updates
ab7aece
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
GH-2464 update simulator version
bb844ac
DmitryBespalov added a commit that referenced this issue Apr 22, 2024
@DmitryBespalov
Merge pull request #3403 from safe-global/GH-2464/ipad-ledger
9caeaeb 
Gh 2464/ipad ledger
@DmitryBespalov
Copy link
Collaborator

@liliya-soroka could you please check this on ipad?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryBespalov DmitryBespalov

Labels
App/Transactions Transactions area bug Doesn't work as expected Major Fix within 2 weeks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DmitryBespalov @liliya-soroka @gglucass @olofedlund