Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Can't connect to some apps via WalletConnect in the mobile browser: "address is invalid error" #3262

Closed
liliya-soroka opened this issue Aug 4, 2023 · 5 comments
Closed

[iOS] Can't connect to some apps via WalletConnect in the mobile browser: "address is invalid error" #3262

liliya-soroka opened this issue Aug 4, 2023 · 5 comments
Assignees
@DmitryBespalov
Labels
bug Doesn't work as expected Major Fix within 2 weeks

Comments

@liliya-soroka
Copy link
Member

liliya-soroka commented Aug 4, 2023 •
edited

Bug description
Can't connect to some apps via WalletConnect : "address is invalid error"
Not a regression issue for the 3.22.0 , the same problem we have in 3.21.0

1st case: default apps list in the app
Steps To Reproduce

  1. Add Polygon safe
  2. go to the Dapps
  3. select "Quickswap"
  4. select connect via WC and select safe app
    Current result: the error about invalid address is displayed

2nd case: dapps is opened in the mobile browser and safe app is called from the wallet connect list of apps

  1. Open Uniswap in the mobile browser on the same device where you have safe mobile app
  2. click connect-> select walletconnect
  3. select Safe mobile app
    Current result: Nothing happens - Uniswap can not open safe mobile app from the wc list of wallets

Expected Result
The dapp should be connected to the safe
Screenshots

RPReplay_Final1691135322.MP4

Device & App version

  • Device/OS: iPhone 11/16.4
  • App version:
    5.22.0(1912)
    Environment
    prod
    Additional info
    (Optional)
@liliya-soroka liliya-soroka added the bug Doesn't work as expected label Aug 4, 2023
@liliya-soroka
Copy link
Member Author

The other case: no error but the app is not connected

RPReplay_Final1691135786.MP4

@liliya-soroka liliya-soroka changed the title [iOS] Can't connect to some apps via WalletConnect : "address is invalid error" [iOS] Can't connect to some apps via WalletConnect on mobile: "address is invalid error" Aug 4, 2023
@liliya-soroka liliya-soroka changed the title [iOS] Can't connect to some apps via WalletConnect on mobile: "address is invalid error" [iOS] Can't connect to some apps via WalletConnect in the mobile browser: "address is invalid error" Aug 4, 2023
@liliya-soroka
Copy link
Member Author

Note , the connection works if the dapp is opened on desctop in the browser and QR code is used for connection

@liliya-soroka liliya-soroka added the Major Fix within 2 weeks label Aug 4, 2023
@DmitryBespalov DmitryBespalov self-assigned this Nov 16, 2023
@liliya-soroka liliya-soroka mentioned this issue Nov 20, 2023
Closed
DmitryBespalov added a commit that referenced this issue Dec 7, 2023
@DmitryBespalov
GH-3262 fixed connection issue
141bd09
@DmitryBespalov DmitryBespalov mentioned this issue Dec 7, 2023
Merged
DmitryBespalov added a commit that referenced this issue Dec 7, 2023
@DmitryBespalov
GH-3262 fixed connection issue (#3370)
b9b0b58
@liliya-soroka
Copy link
Member Author

Connection to some app still doesn't work. The same network was selected in the apps as the safe had:
Polygon:
Sushi
no reaction in safe app at all
Arbitrum:
Balancer
Image

app version 3.25.0 (1982)

DmitryBespalov added a commit that referenced this issue Dec 21, 2023
@DmitryBespalov
GH-3262 Disabled balancer
00963b2
@DmitryBespalov DmitryBespalov mentioned this issue Dec 21, 2023
Merged
DmitryBespalov added a commit that referenced this issue Dec 21, 2023
@DmitryBespalov
GH-3262 Disabled balancer (#3381)
110a695
DmitryBespalov added a commit that referenced this issue Feb 2, 2024
@DmitryBespalov
GH-3262 rewrote approval function
c687fab
@DmitryBespalov DmitryBespalov mentioned this issue Feb 2, 2024
Merged
DmitryBespalov added a commit that referenced this issue Feb 2, 2024
@DmitryBespalov
GH-3262 rewrote approval function (#3392)
994b3ac 
Changes proposed in this pull request:
- Interaction with the wc library extracted to a `ApproverImpl` class behind a testable interface
- Approving logic handles `requiredNamespaces` and `optionalNamespaces` correctly
- Added template-based tests for the approving function
@liliya-soroka
Copy link
Member Author

After the fix it's possible to create a txs on the wrong chain using wallet connect:
Steps:

  1. open https://app.aave.com/ ( Polygon network)
  2. add safe on Arbitrum
  3. Connect Arbitrum Safe to the save on Polygon
  4. click "Enable E-Mode"
  5. The tx from Polygon aave is created in the mobile app on Arbitrum
    Need to check that the dapp and safe are on the same chain
    I have tried the same on web app => the tx creation is rejected in the AAve app with request to change to the correct chain

Image

@DmitryBespalov
Copy link
Collaborator

that's an issue that needs repair.

DmitryBespalov added a commit that referenced this issue Mar 14, 2024
@DmitryBespalov
GH-3262 guard for the same chainid in incoming request
c50a242
@DmitryBespalov DmitryBespalov mentioned this issue Mar 18, 2024
Merged
DmitryBespalov added a commit that referenced this issue Mar 18, 2024
@DmitryBespalov
Merge pull request #3399 from safe-global/GH-3262/chainid-in-request
e7458a9 
GH-3262 guard for the same chainid in incoming request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryBespalov DmitryBespalov

Labels
bug Doesn't work as expected Major Fix within 2 weeks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DmitryBespalov @liliya-soroka