Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENS name entry visual differences with the UI design #64

Closed
5 tasks done
DmitryBespalov opened this issue May 11, 2020 · 1 comment · Fixed by #112
Closed
5 tasks done

ENS name entry visual differences with the UI design #64

DmitryBespalov opened this issue May 11, 2020 · 1 comment · Fixed by #112
Assignees
@DmitryBespalov
Labels
bug Doesn't work as expected
Milestone
Sprint 3 "Kyoto"

Comments

@DmitryBespalov
Copy link
Collaborator

DmitryBespalov commented May 11, 2020 •
edited
Loading

  • The ENS name is auto-capitalized, this should not be the case. Also, the grammar correction should be disabled.
  • Add "." to the keyboard by default (I think there should be a separate keyboard for that)
  • The text field border and icon are not what the UI specifies
  • The check mark icon is in the wrong place (should be near the "Address found" text)
  • The address text is not bold as it should be in the design.
@DmitryBespalov DmitryBespalov added the bug Doesn't work as expected label May 11, 2020
@sche
Copy link
Contributor

sche commented May 11, 2020

  • Add "." to the keyboard by default (I think there should be a separate keyboard for that)

@DmitryBespalov DmitryBespalov added this to the Sprint 3 milestone May 12, 2020
@DmitryBespalov DmitryBespalov self-assigned this May 13, 2020
DmitryBespalov pushed a commit that referenced this issue May 13, 2020
gh-64 adjusted the ui
4dcf71e
DmitryBespalov pushed a commit that referenced this issue May 13, 2020
gh-64 moved out system images to a central location
c4ec5cf
@DmitryBespalov DmitryBespalov mentioned this issue May 13, 2020
Merged
DmitryBespalov pushed a commit that referenced this issue May 13, 2020
gh-64 fixing crash
2967c4a
DmitryBespalov pushed a commit that referenced this issue May 13, 2020
Merge branch 'gh-64' of github.com:gnosis/safe-ios into gh-65
0ebebc5
DmitryBespalov pushed a commit that referenced this issue May 13, 2020
Merge branch 'master' of github.com:gnosis/safe-ios into gh-64
9856330
DmitryBespalov pushed a commit that referenced this issue May 13, 2020
Merge pull request #112 from gnosis/gh-64
e884693 
Gh 64 enter ens name UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitryBespalov DmitryBespalov

Labels
bug Doesn't work as expected
Projects
None yet
Milestone
Sprint 3 "Kyoto"
Development

Successfully merging a pull request may close this issue.

Gh 64 enter ens name UI safe-global/safe-ios
2 participants
@DmitryBespalov @sche