Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push notifications for signing transactions #716

Closed
5 tasks done
DmitryBespalov opened this issue Nov 17, 2020 · 2 comments
Closed
5 tasks done

Push notifications for signing transactions #716

DmitryBespalov opened this issue Nov 17, 2020 · 2 comments
Assignees
@sche
Labels
enhancement New feature or request
Milestone
Sprint 17 "Hannover"

Comments

@DmitryBespalov
Copy link
Collaborator

DmitryBespalov commented Nov 17, 2020 •
edited by sche

Changes to the push notification registration

  • Generate UUID on the device and store it for push notification requests
  • Implement hashing of the registration request
  • Add timestamp and signatures fields to the registration request with the signature of the imported owner key (if present)
  • Send registration request after:
    • first safe was added
    • cloud messaging token updated
    • safe added
    • safe removed
    • owner key imported
    • owner key removed
  • Support receiving new CONFIRMATION_REQUEST notification
    • type: CONFIRMATION_REQUEST
    • address: safe address checksummed
    • safeTxHash: transaction hash to open when a push notification is tapped

See the specification for more details: https://docs.google.com/document/d/1RqIfZkqdS_TZ4IQVjeWUhNI1ZguD3NfpohSSRLVxB5Q/edit#
@DmitryBespalov DmitryBespalov added the enhancement New feature or request label Nov 17, 2020
@DmitryBespalov DmitryBespalov added this to the Sprint 17 "..." milestone Nov 24, 2020
@sche sche self-assigned this Nov 25, 2020
sche pushed a commit that referenced this issue Nov 25, 2020
gh-716 update RegisterNotificationTokenRequest
8c9350d
sche pushed a commit that referenced this issue Nov 25, 2020
gh-716 handle CONFIRMATION_REQUEST pushes; add unit tests
051838b
sche pushed a commit that referenced this issue Nov 26, 2020
gh-716 make adjustments
2175b72
sche pushed a commit that referenced this issue Nov 30, 2020
gh-716 add one more test
786877f
sche pushed a commit that referenced this issue Nov 30, 2020
gh-716 make timestamp optional
d5a2105
sche pushed a commit that referenced this issue Nov 30, 2020
gh-716 improvements
5583f6f
sche pushed a commit that referenced this issue Nov 30, 2020
gh-716 improvements
6c73ebe
sche pushed a commit that referenced this issue Nov 30, 2020
gh-716 fix tests
72ff4e9
sche pushed a commit that referenced this issue Nov 30, 2020
Merge pull request #730 from gnosis/gh-716-push-notifications
3a2752e 
Gh 716 push notifications
@liliya-soroka
Copy link
Member

The task is blocked for QA by back-end task - safe-global/safe-transaction-service#190.

@liliya-soroka
Copy link
Member

Verified
app version 2.7.0 (229)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sche sche

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 17 "Hannover"
Development

No branches or pull requests
3 participants
@DmitryBespalov @liliya-soroka @sche