Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create screen #3286

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Create screen #3286

merged 2 commits into from
Aug 10, 2023

Conversation

MouazAlzahabi
Copy link
Contributor

@MouazAlzahabi MouazAlzahabi commented Aug 10, 2023

Handles #3275

Note: The presented data is dummy, and the entry point (Safe settings) to show the screen also dummy because it might be changed later so it's just about the UI

Simulator Screenshot - iPhone 14 Pro - 2023-08-10 at 10 23 49

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #3286 (342048d) into main (8197b41) will decrease coverage by 1.73%.
Report is 1767 commits behind head on main.
The diff coverage is 0.53%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##            main   #3286      +/-   ##
========================================
- Coverage   8.75%   7.02%   -1.73%     
========================================
  Files        620     766     +146     
  Lines      31233   41540   +10307     
========================================
+ Hits        2733    2920     +187     
- Misses     28500   38620   +10120     
Files Changed Coverage Δ
Multisig/App/AppDelegate+Messaging.swift 0.00% <0.00%> (ø)
Multisig/App/AppDelegate.swift 0.00% <0.00%> (ø)
Multisig/App/SceneDelegate.swift 0.00% <0.00%> (-52.71%) ⬇️
Multisig/App/RemoteNotificationHandler.swift 7.90% <1.66%> (-11.66%) ⬇️

... and 444 files with indirect coverage changes

@MouazAlzahabi MouazAlzahabi merged commit 3bcc321 into main Aug 10, 2023
2 checks passed
@MouazAlzahabi MouazAlzahabi deleted the GH-3275/Security-Overview-Screen branch August 10, 2023 13:14
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants