Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipdb dependency #120

Closed
wants to merge 1 commit into from
Closed

Remove ipdb dependency #120

wants to merge 1 commit into from

Conversation

fmrsabino
Copy link
Collaborator

  • Removes ipdb from the project as this dependency is not being used.

@fmrsabino fmrsabino self-assigned this May 24, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner May 24, 2024 09:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9221715523

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.646%

Totals Coverage Status
Change from base Build 9189466938: 0.0%
Covered Lines: 1909
Relevant Lines: 2106

💛 - Coveralls

@Uxio0
Copy link
Member

Uxio0 commented May 27, 2024

This is a dev requirement not affecting production image. Maybe you are not using it, but ipdb is required for debugging. I don't think it should be removed

@fmrsabino
Copy link
Collaborator Author

This is a dev requirement not affecting production image. Maybe you are not using it, but ipdb is required for debugging. I don't think it should be removed

In my opinion it should then be a dependency installed by the user no? As each user might have different requirements when it comes to debugging.

@fmrsabino
Copy link
Collaborator Author

I also have no strong opinion regarding this but I see the dev requirements as the dependencies that we use to validate the state of the project but that should not be bundled. So for each dependency it'd be good to understand why we have it listed.

@Uxio0
Copy link
Member

Uxio0 commented Jun 11, 2024

IMHO dev dependencies are meant for development, and they are a sane standard for working in the project, without requiring the user to go search for the needed tools. Ipdb is a really basic dev dependency, and I wouldn't remove it

@fmrsabino
Copy link
Collaborator Author

IMHO dev dependencies are meant for development, and they are a sane standard for working in the project, without requiring the user to go search for the needed tools. Ipdb is a really basic dev dependency, and I wouldn't remove it

Ok I will close the PR 👍 (as mentioned I don't have a strong opinion on this matter but a slight preference to reduce the number of dependencies that the project lists and leave the dev environment open for each user when it comes to tooling).

@fmrsabino fmrsabino closed this Jun 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants