Rename requiredPrefund
to missingAccountFunds
#124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a minor suggestion resulting from the audit where the
validateUserOp
parameter names (specifically for the required account fund transfer to the entrypoint) did not exactly match the name from the ERC.Note that the test entrypoint was slightly adjusted to more closely model the behaviour of the reference entrypoint, where left-over user balances are considered when computing the
missingAccountFunds
to pass into thevalidateUserOp
call:I noticed this while looking for instances of
requiredPrefund
in the codebase. All tests continue to pass 🎉.Another minor change, I noticed that
prettier .
was not picking up.sol
files anymore, so I adjusted the NPM scripts to explicitly format and check them.