Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimlico based changes for examples/4337-gas-metering #401

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Apr 26, 2024

This PR intends to use the latest EntryPoint v0.7 along with the new paymaster from Pimlico. Fixes #294

Current Blockers

  • Pimlico Paymasters are still having some problems during execution and estimation.
  • preVerificationGas related estimations are still off by a bit.

The Pimlico team have been informed regarding the same at the time of writing this issue.

Changes completed/in-progress

  • Using base-sepolia as well (sepolia sometimes has a high gas cost)
  • Using new signing struct with the latest 4337 Safe Module
  • Update of permissionless package

Things remaining (and nice to do)

  • Checking compatibility with the Pimlico Gas Metering Task
  • Creating the Table with Pimlico-based (with/out paymaster) gas usage of Safe 4337 Module (using EntryPoint v0.7)
  • Possible refactoring of the code a bit more for easier future changes and comprehension.

@remedcu remedcu self-assigned this Apr 26, 2024
@remedcu remedcu changed the title Pimlico based changes for gas metering Pimlico based changes for examples/4337-gas-metering Apr 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9098338109

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9062559032: 0.0%
Covered Lines: 39
Relevant Lines: 39

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 15, 2024

Pull Request Test Coverage Report for Build 9253109283

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 9250859802: 0.0%
Covered Lines: 147
Relevant Lines: 147

💛 - Coveralls

@mmv08 mmv08 force-pushed the 4337-gas-metering-pimlico branch from 405e82f to 91fda80 Compare May 17, 2024 12:41
@mmv08 mmv08 force-pushed the 4337-gas-metering-pimlico branch from a4dfec9 to 0f3c8af Compare May 21, 2024 10:21
@mmv08 mmv08 force-pushed the 4337-gas-metering-pimlico branch 2 times, most recently from 9c49db7 to 0edbbfe Compare May 22, 2024 10:10
@mmv08 mmv08 force-pushed the 4337-gas-metering-pimlico branch from 0edbbfe to 47eb42b Compare May 22, 2024 11:33
@mmv08 mmv08 force-pushed the 4337-gas-metering-pimlico branch from d1d1835 to 11d6e08 Compare May 22, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 4337-gas-metering/pimlico to use v0.7 EntryPoint
3 participants