-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pimlico based changes for examples/4337-gas-metering
#401
Draft
remedcu
wants to merge
13
commits into
main
Choose a base branch
from
4337-gas-metering-pimlico
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,539
−763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remedcu
changed the title
Pimlico based changes for gas metering
Pimlico based changes for Apr 26, 2024
examples/4337-gas-metering
…gas-metering-pimlico
Pull Request Test Coverage Report for Build 9098338109Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9253109283Details
💛 - Coveralls |
mmv08
force-pushed
the
4337-gas-metering-pimlico
branch
from
May 17, 2024 12:41
405e82f
to
91fda80
Compare
mmv08
force-pushed
the
4337-gas-metering-pimlico
branch
from
May 21, 2024 10:21
a4dfec9
to
0f3c8af
Compare
mmv08
force-pushed
the
4337-gas-metering-pimlico
branch
2 times, most recently
from
May 22, 2024 10:10
9c49db7
to
0edbbfe
Compare
mmv08
force-pushed
the
4337-gas-metering-pimlico
branch
from
May 22, 2024 11:33
0edbbfe
to
47eb42b
Compare
mmv08
force-pushed
the
4337-gas-metering-pimlico
branch
from
May 22, 2024 12:20
d1d1835
to
11d6e08
Compare
…sfer fails for some reason
…gas-metering-pimlico
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to use the latest
EntryPoint v0.7
along with the newpaymaster
from Pimlico. Fixes #294Current Blockers
preVerificationGas
related estimations are still off by a bit.The Pimlico team have been informed regarding the same at the time of writing this issue.
Changes completed/in-progress
base-sepolia
as well (sepolia
sometimes has a high gas cost)permissionless
packageThings remaining (and nice to do)
v0.7
)