Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Docker Files To Dist Directory #424

Merged
merged 1 commit into from
May 21, 2024
Merged

Copy Docker Files To Dist Directory #424

merged 1 commit into from
May 21, 2024

Conversation

nlordell
Copy link
Collaborator

This PR changes the build command for the 4337-local-bundler package to also copy the docker files to the dist output.

This became an issue for me since #420. I use podman(-compose) which does not have the behaviour of walking up the directory tree in order to find a docker-compose.yaml to use for podman compose ... commands. The issue lies with the fact that that this relative path:

const root = path.join(__dirname, '..', '..')

Is no longer valid for build outputs since dist has an extra level of nesting since #420 as it includes the hardhat.config.ts in its build output. To fix this, the Docker compose related files are also copied to the dist directory, which gives us this tree and ensures that the root path is correct once again.

packages/4337-local-bundler/dist
├── docker
│   └── bundler
│       └── Dockerfile
├── docker-compose.yaml
├── hardhat.config.d.ts
├── hardhat.config.js
└── src
    ├── bin
    │   ├── test.d.ts
    │   └── test.js
    ├── deploy
    │   ├── entrypoint.d.ts
    │   ├── entrypoint.js
    │   ├── safe.d.ts
    │   └── safe.js
    ├── index.d.ts
    ├── index.js
    ├── testing.d.ts
    ├── testing.js
    └── types
        ├── hardhat.d.ts
        └── hardhat.js

@nlordell nlordell requested a review from a team as a code owner May 17, 2024 09:24
@nlordell nlordell requested review from akshay-ap, mmv08 and remedcu and removed request for a team May 17, 2024 09:24
@mmv08 mmv08 merged commit 32fc6f5 into main May 21, 2024
4 checks passed
@mmv08 mmv08 deleted the copy-docker-files branch May 21, 2024 08:40
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants