Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix import in Windows 10 + Chrome #2582

Merged
merged 2 commits into from Jul 26, 2021
Merged

Fix import in Windows 10 + Chrome #2582

merged 2 commits into from Jul 26, 2021

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jul 26, 2021

What it solves

Resolves #2578

How this PR fixes it

It allows file type not to be defined but also includes a file extension validation in order to still do a minimum check that a valid file is being uploaded

How to test it

It can only be tested using Chrome in Windows 10
If an office suite is installed it may be possible that the issue is not repeatable anymore. I can just confirm that it's possible with a clean Windows 10 or with LibreOffice installed

@dasanra dasanra requested a review from mmv08 July 26, 2021 12:26
@dasanra dasanra self-assigned this Jul 26, 2021
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@tschubotz
Copy link
Member

I just tested this in my Win10 VM and I was able to successfully import the csv from the issue!

@dasanra dasanra changed the title Fix import windows chrome Fix import in Windows 10 + Chrome Jul 26, 2021
@dasanra dasanra merged commit 5d27d3a into dev Jul 26, 2021
@dasanra dasanra deleted the fix-import-windows-chrome branch July 26, 2021 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import CSV files in Windows
3 participants