Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Cannot import CSV files in Windows #2578

Closed
tschubotz opened this issue Jul 26, 2021 · 4 comments · Fixed by #2582
Closed

Cannot import CSV files in Windows #2578

tschubotz opened this issue Jul 26, 2021 · 4 comments · Fixed by #2582
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Milestone

Comments

@tschubotz
Copy link
Member

tschubotz commented Jul 26, 2021

Description

Cannot import CSV files

Environment

  • Browser: Chrome on Windows 10
  • Wallet: Metamask
  • Safe: -
  • Environment:
    • production (mainnet) 3.10.0

Steps to reproduce

  1. Export address book
  2. Import CSV

Expected result

  • No issues

Obtained result

image

Misc

This is the file:

gnosis-safe-address-book-2021-07-26.csv

@tschubotz tschubotz added Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. labels Jul 26, 2021
@tschubotz
Copy link
Member Author

@francovenica could you please check if you have the same issue when you get online? If yes, I would promite this to critical.

cc @dasanra

@dasanra
Copy link
Collaborator

dasanra commented Jul 26, 2021

Checked this issue. Is related to this:
https://stackoverflow.com/questions/51724649/mime-type-of-file-returning-empty-in-javascript-on-some-machines

The only solution I see, as we are not going to add a key on windows registry, is to also accept empty file type '' as valid and rely in all other validations

@francovenica
Copy link
Contributor

I have no issues with the csv's I've been using. Maybe there is something specific about that .csv file
image

@francovenica
Copy link
Contributor

francovenica commented Jul 26, 2021

Here is another article that talks about the issue Dani mentioned in his comment
https://textslashplain.com/2018/07/26/be-skeptical-of-client-reported-mime-content-types/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants