Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Show a meaningful error message on Safe creation #3271

Merged
merged 3 commits into from Jan 12, 2022
Merged

Show a meaningful error message on Safe creation #3271

merged 3 commits into from Jan 12, 2022

Conversation

katspaugh
Copy link
Member

It was saying just "Safe creation failed". I've added an actual error message.

Screenshot 2022-01-10 at 16 59 22

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 10, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@coveralls
Copy link

coveralls commented Jan 10, 2022

Pull Request Test Coverage Report for Build 1681918905

  • 1 of 12 (8.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 32.4%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/opening/index.tsx 0 1 0.0%
src/routes/CreateSafePage/components/SafeCreationProcess.tsx 1 11 9.09%
Totals Coverage Status
Change from base Build 1678787590: -0.03%
Covered Lines: 3114
Relevant Lines: 8561

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 10, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1681952216

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katspaugh katspaugh removed the request for review from DiogoSoaress January 10, 2022 17:48
@francovenica
Copy link
Contributor

francovenica commented Jan 10, 2022

Is this the message expected? (just set the gas limit really low to make it fail on purpose)
image

@katspaugh
Copy link
Member Author

Looks like there's an error in that error. Will fix.

@katspaugh
Copy link
Member Author

katspaugh commented Jan 11, 2022

Added a workaround for the formatting issue.
Screenshot 2022-01-11 at 11 10 47

Other errors seem more legible:

Screenshot 2022-01-11 at 11 11 00

@francovenica
Copy link
Contributor

Looks good to me. Had both messages just fine (one on each attempt)
image

@katspaugh katspaugh merged commit 2843389 into dev Jan 12, 2022
@katspaugh katspaugh deleted the create-err branch January 12, 2022 20:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants