This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Change Safe App name TextField from readonly to disabled #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
E2E Tests Failed Failed tests:
|
Pull Request Test Coverage Report for Build 1744975826
💛 - Coveralls |
|
All bueno. Muchas gracias gentlemen ;) |
mmv08
reviewed
Jan 25, 2022
| &.Mui-disabled { | ||
| color: rgba(0, 0, 0, 0.54); | ||
| &.Mui-error { | ||
| color: ${theme.colors.error}; |
There was a problem hiding this comment.
Isn't the theme passed via props like here https://styled-components.com/docs/advanced#theming?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves safe-global/safe-react-apps#272
How this PR fixes it
By changing the textfield from readOnly to disabled and tweaking some styles
How to test it
Try to add a custom app and click in the safe app name field. Nothing should happen. The label remains in the same place and no animation is performed
Make the app fail for manifest not found. The label should be red and when you click nothing happens