Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version byte to follow EIP191 #15

Closed
Georgi87 opened this issue Apr 14, 2018 · 0 comments
Closed

Add version byte to follow EIP191 #15

Georgi87 opened this issue Apr 14, 2018 · 0 comments
Assignees
@rmeissner
Labels
enhancement

Comments

@Georgi87
Copy link
Contributor

See: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-191.md

The version byte is for future changes (and to be backwards compatible to the current eth_sign).If we add this 0-byte to comply to the EIP we have a better change that Trezor and Ledger will support this message signing.
@rmeissner rmeissner self-assigned this Apr 16, 2018
rmeissner added a commit that referenced this issue Apr 16, 2018
@rmeissner
Implement #15: Add version byte for hashing
b14eb2c
@rmeissner rmeissner mentioned this issue Apr 17, 2018
Merged
11 tasks
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
@rmeissner
Implement safe-global#15: Add version byte for hashing
0f26c38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmeissner rmeissner

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Georgi87 @rmeissner