Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly returning data from tx execution through module #728

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Jan 12, 2024

The execTransactionFromModuleReturnData(...) returned data from guard execution, if a guard was enabled. It was rectified by assigning the returnData to the return value from the execute(...) and then running the post-tx checks in the guard. As these pre and post-checks through guards were shared between all execTransactionFromModule*(...), internal functions were written for the same.

Closes #708

@remedcu remedcu added the bug label Jan 12, 2024
@remedcu remedcu self-assigned this Jan 12, 2024
@coveralls
Copy link

coveralls commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7503212266

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 94.591%

Totals Coverage Status
Change from base Build 7476408467: 0.04%
Covered Lines: 400
Relevant Lines: 408

💛 - Coveralls

@remedcu remedcu marked this pull request as ready for review January 12, 2024 13:00
@remedcu remedcu requested review from a team, rmeissner, nlordell, akshay-ap and mmv08 and removed request for a team January 12, 2024 13:00
Copy link
Member

@mmv08 mmv08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's also wait for @nlordell and @akshay-ap reviews, as I'd deem this a security-critical change and the more eyes, the better

Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one OCD nit 😛.

@remedcu remedcu merged commit 965e2e9 into main Jan 12, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
@nlordell nlordell deleted the bug/execTransactionFromModuleReturnData-mit-guard branch April 22, 2024 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe 1.5.0] execTransactionFromModuleReturnData Will Return Guard returndata
4 participants