Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "origin" to transaction #61

Closed
rmeissner opened this issue Feb 6, 2020 · 4 comments
Closed

Add "origin" to transaction #61

rmeissner opened this issue Feb 6, 2020 · 4 comments
Assignees

Comments

@rmeissner
Copy link
Member

It is planned to allow Safe apps to submit transactions to the interface. As an owner of a Safe I would like to know from which service the transaction provided. For this we should add a "origin" field when sending the transaction meta to the service.

Notes:

  • origin field is not part of the safe tx hash and therefore is not 100% trustworthy (maybe this should be mentioned in swagger) -> malicious owner could abuse this, but the advantages outweight this small risk
  • origin field should be a string
@Uxio0
Copy link
Member

Uxio0 commented Feb 12, 2020

@rmeissner I will set the maximum length of the field to 100 characters, is that ok?

@rmeissner
Copy link
Member Author

In my opinion that should be sufficient

Uxio0 added a commit that referenced this issue Feb 12, 2020
@Uxio0 Uxio0 closed this as completed in 701f484 Feb 13, 2020
@nicosampler
Copy link

Hi @Uxio0 I just send a TX (POST) with the origin field:
image

and then, when I request the TX (GET) https://safe-transaction.rinkeby.gnosis.io/api/v1/safes/0xEd99E368FCD7404045D1F20cb29274ecd9Ebf428/transactions/ the origin field for the nonce 76 is null.

any Idea what can be wrong? note that I'm on Rinkeby

@rmeissner
Copy link
Member Author

If you post to staging dev env you also need to get from staging dev env (and not production)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants