Bump safe-eth-py to v5.4.1 #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
force-pushed
the
bump-safe-eth-py
branch
2 times, most recently
from
632a081
to
39938ee
Compare
Uxio0
force-pushed
the
bump-safe-eth-py
branch
2 times, most recently
from
4cbf334
to
351569c
Compare
moisses89
reviewed
May 22, 2023
| self.assertEqual(SafeMasterCopy.objects.count(), 8) | ||
| self.assertEqual(SafeMasterCopy.objects.l2().count(), 1) | ||
| self.assertEqual(ProxyFactory.objects.count(), 4) | ||
| self.assertEqual(SafeMasterCopy.objects.count(), 9) |
There was a problem hiding this comment.
Could you add a comment why we expect 9? or maybe split by version.
There was a problem hiding this comment.
I mean, we expect to support 9 master copies in mainnet, 2 l2s and 5 proxies. At least for mainnet I wanted to do this check
- Fix tests
moisses89
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.