Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit Transfers #1937

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Limit Transfers #1937

merged 1 commit into from
Mar 21, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Mar 21, 2024 •
edited

@Uxio0 Uxio0 requested a review from a team as a code owner March 21, 2024 10:39
@Uxio0 Uxio0 force-pushed the limit-transfers branch 3 times, most recently from de2d0c3 to a7424b8 Compare March 21, 2024 15:17
@Uxio0
Limit Transfers
d516ba4 
- Prevent issues with Safes receiving a lot of transfers every second
moisses89
moisses89 approved these changes Mar 21, 2024
View reviewed changes
config/settings/base.py

# Endpoints
TX_SERVICE_ALL_TXS_ENDPOINT_LIMIT_TRANSFERS = env.int(
"TX_SERVICE_ALL_TXS_ENDPOINT_LIMIT_TRANSFERS", default=1_000
Copy link
Member

@moisses89 moisses89 Mar 21, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion here but maybe would be better default 0 and add logic to don't limit by default.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking on our providers, I think it's better to do it as the default. Also adding logic for not limiting would imply modifying the code way more

@Uxio0 Uxio0 merged commit cf23d6f into main Mar 21, 2024
6 checks passed
@Uxio0 Uxio0 deleted the limit-transfers branch March 21, 2024 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safes with a lot of transfers take a lot to load
2 participants
@Uxio0 @moisses89