Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for trusted csrf origins #644

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

InoMurko
Copy link
Contributor

@InoMurko InoMurko commented Jan 19, 2022

What was wrong?

Support for CSRF trusted origins https://docs.djangoproject.com/en/3.2/ref/settings/#csrf-trusted-origins
which is useful for different kinds of deployments.
Relevant:
safe-global/safe-config-service#402
#640
Closes #

How was it fixed?

Added reading env CSRF_TRUSTED_ORIGINS and setting CSRF_TRUSTED_ORIGINS.
@gnosis/safe-services

@InoMurko InoMurko requested review from a team, rmeissner, fmrsabino and Uxio0 January 19, 2022 18:31
@github-actions
Copy link

github-actions bot commented Jan 19, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@InoMurko
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@InoMurko InoMurko force-pushed the inomurko/csrf_trusted_origins branch from 0309d71 to 019ccbf Compare January 19, 2022 18:40
github-actions bot added a commit that referenced this pull request Jan 19, 2022
@coveralls
Copy link

coveralls commented Jan 19, 2022

Coverage Status

Coverage decreased (-1.7%) to 87.067% when pulling e862fdc on enyalabs:inomurko/csrf_trusted_origins into 9532254 on gnosis:master.

config/settings/production.py Outdated Show resolved Hide resolved
@Uxio0 Uxio0 merged commit 682f272 into safe-global:master Jan 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
@InoMurko InoMurko deleted the inomurko/csrf_trusted_origins branch January 20, 2022 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants