Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get SafeInfo from blockchain if nonce=0 #852

Merged
merged 2 commits into from
May 23, 2022
Merged

Get SafeInfo from blockchain if nonce=0 #852

merged 2 commits into from
May 23, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented May 23, 2022 •
edited

  • Get SafeInfo from blockchain (instead of SafeLastStatus table) if nonce=0 or not found on the DB.
  • Fixes issues with Safes not indexed or not L2 Safes in L2 networks

@Uxio0 Uxio0 requested a review from a team as a code owner May 23, 2022 11:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2370984476

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 88.101%
Totals Coverage Status
Change from base Build 2359223568: 0.01%
Covered Lines: 5716
Relevant Lines: 6488
💛 - Coveralls

@Uxio0 Uxio0 merged commit d006a44 into master May 23, 2022
@Uxio0 Uxio0 deleted the safe-info-use-blockchain branch May 23, 2022 12:07
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uxio0 @coveralls