Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeStatus and SafeLastStatus accept blank enabled_modules #853

Conversation

moisses89
Copy link
Member

What was wrong?

LastSafeStatus required enabled_modules always, this field should be optional.

How was it fixed?

Configuring the model SafeStatus.enabled_modules blank=True to accept empty values.

@moisses89 moisses89 requested a review from a team as a code owner May 23, 2022 11:42
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2371018765

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.086%

Totals Coverage Status
Change from base Build 2359223568: 0.0%
Covered Lines: 5708
Relevant Lines: 6480

💛 - Coveralls

@Uxio0 Uxio0 merged commit 2f91221 into master May 23, 2022
@Uxio0 Uxio0 deleted the 843-it-should-be-possible-to-add-the-latest-state-for-a-safe-without-modules branch May 23, 2022 11:49
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It should be possible to add the latest state for a Safe without modules
3 participants