Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to get token logos from coingecko #856

Merged
merged 1 commit into from
May 25, 2022
Merged

Add method to get token logos from coingecko #856

merged 1 commit into from
May 25, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented May 23, 2022

No description provided.

@Uxio0 Uxio0 requested a review from a team as a code owner May 23, 2022 15:44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2383607184

  • 29 of 32 (90.63%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 88.159%
Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_transaction_service/tokens/clients/coingecko_client.py 26 29 89.66%
Totals Coverage Status
Change from base Build 2383601569: 0.06%
Covered Lines: 5740
Relevant Lines: 6511
💛 - Coveralls

@Uxio0 Uxio0 merged commit c51ad56 into master May 25, 2022
@Uxio0 Uxio0 deleted the coingecko-get-logos branch May 25, 2022 15:14
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @fmrsabino