Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return SafeStatus always from blockchain #884

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Return SafeStatus always from blockchain #884

merged 2 commits into from
Jun 6, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jun 6, 2022 •
edited

  • Return SafeStatus always from blockchain
  • Revert SafeLastStatus changes to the Safe info view
  • Set version 4.3.3

@Uxio0 Uxio0 requested a review from a team as a code owner June 6, 2022 12:50
@Uxio0 Uxio0 changed the title revert use blockchain info Return SafeStatus always from blockchain Jun 6, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2447828314

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 88.09%
Files with Coverage Reduction New Missed Lines %
safe_transaction_service/history/services/safe_service.py 7 86.82%
Totals Coverage Status
Change from base Build 2447759621: -0.1%
Covered Lines: 5747
Relevant Lines: 6524
💛 - Coveralls

@Uxio0 Uxio0 merged commit 328d3a7 into master Jun 6, 2022
@Uxio0 Uxio0 deleted the revert-use-blockchain-info branch June 6, 2022 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmeissner rmeissner rmeissner approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@luarx luarx Awaiting requested review from luarx luarx was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @rmeissner