Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SafeLastStatus get_or_create -> get_or_generate #890

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Rename SafeLastStatus get_or_create -> get_or_generate #890

merged 1 commit into from
Jun 9, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jun 9, 2022

  • There's no need to override Django ORM method

@Uxio0
Rename SafeLastStatus get_or_create -> get_or_generate
68b87b9 
- There's no need to override Django ORM method
@Uxio0 Uxio0 requested a review from a team as a code owner June 9, 2022 12:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2468242001

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.107%
Totals Coverage Status
Change from base Build 2468163474: 0.0%
Covered Lines: 5756
Relevant Lines: 6533
💛 - Coveralls

moisses89
moisses89 approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree ;)

@Uxio0 Uxio0 merged commit faa77d1 into master Jun 9, 2022
@Uxio0 Uxio0 deleted the rename-safe-last-status-get-or-create branch June 9, 2022 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@luarx luarx Awaiting requested review from luarx luarx was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @moisses89