Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize InternalTx Indexer #921

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Optimize InternalTx Indexer #921

merged 1 commit into from
Jul 6, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jun 22, 2022

  • When using trace_block, don't use trace_transaction afterwards
  • When using trace_filter, don't filter for from the addresses provided. We are only interested in the incoming transactions (DELEGATE_CALLS) for the addresses

- When using `trace_block`, don't use `trace_transaction` afterwards
- When using `trace_filter`, don't filter for `from` the addresses
  provided. We are only interested in the incoming transactions
  (DELEGATE_CALLS) for the addresses
@Uxio0 Uxio0 requested a review from a team as a code owner June 22, 2022 15:03
@Uxio0
Copy link
Member Author

Uxio0 commented Jun 22, 2022

Related to safe-global/safe-pm#89

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2543204437

  • 38 of 38 (100.0%) changed or added relevant lines in 1 file are covered.
  • 34 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 87.913%

Files with Coverage Reduction New Missed Lines %
safe_transaction_service/history/indexers/internal_tx_indexer.py 3 91.24%
safe_transaction_service/history/services/collectibles_service.py 31 79.57%
Totals Coverage Status
Change from base Build 2541102331: -0.4%
Covered Lines: 5775
Relevant Lines: 6569

💛 - Coveralls

@Uxio0 Uxio0 merged commit bb39344 into master Jul 6, 2022
@Uxio0 Uxio0 deleted the optimize-trace-indexer branch July 6, 2022 13:10
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants