Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters for collectibles SQL query #950

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Add filters for collectibles SQL query #950

merged 1 commit into from
Jul 8, 2022

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jul 7, 2022 •
edited

  • Filter trusted and spam tokens on the collectibles query

@Uxio0 Uxio0 requested a review from a team as a code owner July 7, 2022 15:17
moisses89
moisses89 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coveralls
Copy link

coveralls commented Jul 7, 2022 •
edited

Pull Request Test Coverage Report for Build 2635330212

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 88.369%
Totals Coverage Status
Change from base Build 2630384118: -0.02%
Covered Lines: 5782
Relevant Lines: 6543
💛 - Coveralls

@Uxio0
Copy link
Member Author

Uxio0 commented Jul 7, 2022

Looks good

I think it can be more optimal using a JOIN instead of WHERE IN, I will check tomorrow before merging

@Uxio0
Add filters for collectibles SQL query
e33ca64 
- Add conditional DB index for `spam=True` on Tokens table
@Uxio0 Uxio0 force-pushed the add-filter-collectibles-query branch from 85a4f7a to e33ca64 Compare July 8, 2022 09:54
@Uxio0
Copy link
Member Author

Uxio0 commented Jul 8, 2022

@moisses89 Added a DB index for SPAM tokens

@Uxio0 Uxio0 merged commit 51dc1b7 into master Jul 8, 2022
@Uxio0 Uxio0 deleted the add-filter-collectibles-query branch July 8, 2022 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner rmeissner was automatically assigned from safe-global/safe-services

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uxio0 @coveralls @moisses89