Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: prevent Safe Apps tracking on non-Safe App pages #2548

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Sep 26, 2023

Safe Apps track all RPC requests a lot of which are triggered from the Governance App on the Dashboard. Since this doesn't reflect actual Safe App usage, it should be disabled.

How to test

  • Safe Apps tracking events should not be triggered on the dashboard anymore
  • Events on the /apps page, as well as individual Safe App pages should be still emitted like before.

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Branch preview

✅ Deploy successful!

https://apps_tracking--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@katspaugh
Copy link
Member Author

@dasanra good with you?

@francovenica
Copy link
Contributor

Looks good to me

Visiting the dashboard doesn't make any GTM calls with for safe-apps.
Visiting the apps themselves makes the GTM calls for safe-apps just fine.

@katspaugh katspaugh merged commit 8fcb5df into dev Sep 30, 2023
9 checks passed
@katspaugh katspaugh deleted the apps-tracking branch September 30, 2023 06:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants