Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nonce field styles #2563

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix: nonce field styles #2563

merged 3 commits into from
Oct 2, 2023

Conversation

iamacook
Copy link
Member

What it solves

Partially resolves #2560

How this PR fixes it

The recommended nonce is always shown and the padding applied for the reset nonce button is included in the field width.

How to test it

Open the transaction flow and observe the recommended nonce always shown when a non-existent recommended nonce exists, as well as the value always visible.

Screenshots

recommended-nonce

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Branch preview

✅ Deploy successful!

https://nonce_style--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

francovenica commented Sep 29, 2023

Issue:

If the nonce is lower than the exepected one the dropdown will show you what is the nonce you must select, which is fine, the problem is that if that nonce you are writing matches the exepected nonce, it will show it twice in the dropdown
In this snapshot, the safe has no tx in the queue and the next nonce to execute is 158, so if you write "1" or "15" or "8" it will show the recomended nonce twice in the dropdown
If you write a "9" for example it will be correct, since it is showing the suggested nonce only once
image

image

@iamacook
Copy link
Member Author

iamacook commented Oct 2, 2023

If the nonce is lower than the exepected one the dropdown will show you what is the nonce you must select, which is fine, the problem is that if that nonce you are writing matches the exepected nonce, it will show it twice in the dropdown In this snapshot, the safe has no tx in the queue and the next nonce to execute is 158, so if you write "1" or "15" or "8" it will show the recomended nonce twice in the dropdown If you write a "9" for example it will be correct, since it is showing the suggested nonce only once

This should now be fixed:

nonce

@francovenica
Copy link
Contributor

The issue was fixed. Looks good now:
image

@iamacook iamacook merged commit 0bbd714 into dev Oct 2, 2023
9 checks passed
@iamacook iamacook deleted the nonce-style branch October 2, 2023 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Show a warning/prompt when nonce is above the latest nonce
3 participants