Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification settings link #2578

Merged
merged 6 commits into from
Oct 4, 2023
Merged

feat: notification settings link #2578

merged 6 commits into from
Oct 4, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 2, 2023

What it solves

Resolves unclear notification settings navigation

How this PR fixes it

A "Notifications settings" link has been added to the notification centre footer.

How to test it

Open the notification centre and observe the new, working link in the footer.

Screenshots

image

Older screenshots showcasing the presence:

image

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Branch preview

✅ Deploy successful!

https://notification_settings_link--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook changed the title Notification settings link feat: notification settings link Oct 2, 2023
@katspaugh
Copy link
Member

When you click on ⚙️ Settings, it should close the notifications popup.

@francovenica
Copy link
Contributor

LGTM.
The button is there, takes to the safe settings.
I've checked that it looks fine with different notifcation statuses:
image
image
image

@iamacook iamacook merged commit ca9892c into dev Oct 4, 2023
9 checks passed
@iamacook iamacook deleted the notification-settings-link branch October 4, 2023 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants